[tmva][sofie] Fix Conv+Add fusion null path#21979
Open
markknoffler wants to merge 1 commit intoroot-project:masterfrom
Open
[tmva][sofie] Fix Conv+Add fusion null path#21979markknoffler wants to merge 1 commit intoroot-project:masterfrom
markknoffler wants to merge 1 commit intoroot-project:masterfrom
Conversation
ParseFuseConvAdd returned a null operator while the Add node was marked as fused, which could leave fused output type unregistered and break downstream parsing. Implement the fused Conv+Add parser to produce a valid operator and register the fused output type.
Member
|
Thank you for the PR, can you also add a test for this? Thank you |
Test Results 22 files 22 suites 3d 13h 36m 22s ⏱️ For more details on these failures, see this check. Results for commit 4082b4c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21978.
In SOFIE ONNX parser,
Conv + Addfusion was routed throughParseFuseConvAdd, but that path returned a null operator in the broken implementation. Since parser flow had already marked theAddnode as fused, downstream nodes could observe missing tensor type registration and fail at runtime.This patch implements
ParseFuseConvAddso fused Conv+Add creates a valid fusedROperator_Convand registers the fused output tensor type.Why this matters
Without this fix, a valid
Conv -> Add -> Relugraph can fail during parse with:TMVA::SOFIE ONNX Parser relu op has input tensoradd_out but its type is not yet registeredChanges
tmva/sofie_parsers/src/ParseFuseConvAdd.cxxChecklist
Respected @lmoneta and @sanjibansg,
Could you please review this fix?
Also, I have local bug reproduction scripts, but they are currently not in ROOT standard test layout.
Kindly advise if you would like me to add the regression test in this PR.
With regards,
Samreedh Bhuyan