[cmake] Look for static libxxhash first therewith restoring the symmetry with the builtin provided xxhash library#21996
Merged
dpiparo merged 1 commit intoroot-project:masterfrom Apr 21, 2026
Conversation
1 task
bellenot
requested changes
Apr 21, 2026
| # and then considered with platform-specific prefixes (e.g. lib) and suffixes (e.g. .so), as defined by | ||
| # the variables CMAKE_FIND_LIBRARY_PREFIXES and CMAKE_FIND_LIBRARY_SUFFIXES. Therefore one may specify | ||
| # library file names such as libfoo.a directly. This can be used to locate static libraries on UNIX-like systems. | ||
| find_library(xxHash_LIBRARY NAMES libxxhash.a libxxHash.a xxhash xxHash PATH_SUFFIXES lib) |
Member
There was a problem hiding this comment.
Maybe using the cross-platform static library suffix?
Suggested change
| find_library(xxHash_LIBRARY NAMES libxxhash.a libxxHash.a xxhash xxHash PATH_SUFFIXES lib) | |
| find_library(xxHash_LIBRARY NAMES libxxhash${CMAKE_STATIC_LIBRARY_SUFFIX} libxxHash${CMAKE_STATIC_LIBRARY_SUFFIX} xxhash xxHash PATH_SUFFIXES lib) |
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 83b1f73. |
therewith restoring the symmetry with the builtin provided xxhash library. fixes root-project#21991
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #21991