Skip to content

[io] fix memleak in TFile::Recover UPDATE mode #21999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 1 commit into from
Apr 22, 2026
+3 −3
Merged

[io] fix memleak in TFile::Recover UPDATE mode #21999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions io/io/src/TFile.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2119,7 +2119,6 @@ Int_t TFile::Recover()

if (fWritable && !fFree) fFree = new TList;

TKey *key;
Int_t nrecov = 0;
nwheader = 1024;
Int_t nread = nwheader;
Expand Down Expand Up @@ -2171,14 +2170,15 @@ Int_t TFile::Recover()
TClass *tclass = TClass::GetClass(classname);
if (seekpdir == fSeekDir && tclass && !tclass->InheritsFrom(TFile::Class())
&& strcmp(classname,"TBasket")) {
key = new TKey(this);
TKey *key = new TKey(this);
key->ReadKeyBuffer(bufread);
if (!strcmp(key->GetName(),"StreamerInfo")) {
fSeekInfo = seekkey;
SafeDelete(fInfoCache);
fNbytesInfo = nbytes;
delete key;
} else {
AppendKey(key);
AppendKey(key); // ownership transferred, do not to delete key here
nrecov++;
SetBit(kRecovered);
Info("Recover", "%s, recovered key %s:%s at address %lld",GetName(),key->GetClassName(),key->GetName(),idcur);
Expand Down
Loading