[6.40] [RDF] Always write nominal columns in Snapshot with variations.#22089
Merged
hageboeck merged 2 commits intoroot-project:v6-40-00-patchesfrom Apr 29, 2026
Merged
Conversation
Before, the nominal columns were omitted from the output if their filter didn't pass. This is, however, insufficient, because if at least two variations are run, (some of) the nominal columns might still be in use. The tests have been updated to reflect the fact that the nominal columns are not zeroed out. (cherry picked from commit 2bf9cbb)
When two variations are run, e.g. x_var and y_var, and the computation
graph uses both x and y, the pairs {x, y_var} and {x_var, y} need to be
visible in the output file. This means that the nominal columsn always
need to be written, even if {x, y} would not pass the filter.
(cherry picked from commit 6ce7930)
root-project-bot
requested review from
martamaja10 and
vepadulano
as code owners
Test Results 22 files 22 suites 3d 8h 42m 23s ⏱️ Results for commit a9c34e2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #21246, requested by @hageboeck.