[RF] Replace legacy backend reference in tests with analytical results#22092
Merged
Merged
Conversation
Test Results 22 files 22 suites 3d 11h 42m 20s ⏱️ Results for commit 6694be2. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
legacy_eval_backend
branch
from
eea4383 to
fd1d445
Compare
guitargeek
changed the title
guitargeek
force-pushed
the
legacy_eval_backend
branch
from
fd1d445 to
a219a65
Compare
Some RooFit unit tests previously used the legacy evaluation backend to produce reference fit results, either as a direct comparison or guarded by `#ifdef ROOFIT_LEGACY_EVAL_BACKEND`. They are rewritten to compare against analytically-computed reference values, so they now exercise the CPU backend whether or not the legacy backend is built. Also, add missing `#ifdef ROOFIT_LEGACY_EVAL_BACKEND` guard to some tests in `testLikelihoodGradientJob.cxx`, because these tests check for bitwise equality with the legacy backend fit results.
guitargeek
force-pushed
the
legacy_eval_backend
branch
from
a219a65 to
6694be2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some RooFit unit tests previously used the legacy evaluation backend to produce reference fit results, either as a direct comparison or guarded by
#ifdef ROOFIT_LEGACY_EVAL_BACKEND. They are rewritten to compare against analytically-computed reference values, so they now exercise the CPU backend whether or not the legacy backend is built.Also, add missing
#ifdef ROOFIT_LEGACY_EVAL_BACKENDguard to some tests intestLikelihoodGradientJob.cxx, because these tests check for bitwise equality with the legacy backend fit results.