[RF] RooONNXFunc fixups#22099
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Apr 29, 2026
Merged
Conversation
* copying `_funcName` was forgotten
* `d_inputFlt` should start from zero so the derivatives get correctly
accumulated (noticed when running benchmarks and tests)
lmoneta
approved these changes
Apr 29, 2026
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
Thank you Jonas for the fixes!
Test Results 21 files 21 suites 3d 8h 32m 12s ⏱️ For more details on these failures, see this check. Results for commit 1f257f3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copying
_funcNamewas forgottend_inputFltshould start from zero so the derivatives get correctly accumulated (noticed when running benchmarks and tests)