Skip to content

[graf3d][gui][hist][roofit] Fix a few compiler warnings #22207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitargeek merged 1 commit into from
May 10, 2026
+6 −9
Merged

[graf3d][gui][hist][roofit] Fix a few compiler warnings #22207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion graf3d/gl/src/TKDEFGT.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ void TKDEFGT::Kcenter(const TGL5DDataSet *sources)
}
}

for (UInt_t i = 0, nd = 0 ; i < nP; i++, nd += fDim) {
for (UInt_t i = 0; i < nP; i++) {
fXboxsz[fIndx[i]]++;
UInt_t ibase = fIndx[i] * fDim;
fXC[ibase] += sources->V1(i);
Expand Down
4 changes: 1 addition & 3 deletions gui/guihtml/src/TGHtmlIndex.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,14 @@
TGHtmlElement *TGHtml::TokenByIndex(int N, int /*flag*/)
{
TGHtmlElement *p;
int n;

if (N == 0) return fPFirst;

if (N > fNToken / 2) {
// Start at the end and work back toward the beginning
for (p = fPLast, n = fNToken; p; p = p->fPPrev) {
for (p = fPLast; p; p = p->fPPrev) {
if (p->fType != Html_Block) {
if (p->fElId == N) break;
--n;
}
}
} else {
Expand Down
4 changes: 2 additions & 2 deletions hist/hist/src/TSpline.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ TSpline3::TSpline3(const char *title,
// them with node information
fPoly = new TSplinePoly3[fNp];
for (Int_t i=0; i<fNp; ++i) {
Double_t xx, yy;
Double_t xx = 0., yy = 0.;
g->GetPoint(i,xx,yy);
fPoly[i].X()=xx;
fPoly[i].Y()=yy;
Expand Down Expand Up @@ -1355,7 +1355,7 @@ TSpline5::TSpline5(const char *title,
// them with node information
fPoly = new TSplinePoly5[fNp];
for (Int_t i=0; i<fNp-beg; ++i) {
Double_t xx, yy;
Double_t xx = 0., yy = 0.;
g->GetPoint(i,xx,yy);
fPoly[i+beg].X()=xx;
fPoly[i+beg].Y()=yy;
Expand Down
5 changes: 2 additions & 3 deletions roofit/histfactory/src/HistoToWorkspaceFactoryFast.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,9 +1048,8 @@ RooArgList HistoToWorkspaceFactoryFast::createObservables(const TH1 *hist, RooWo
// Get a RooArgSet of the observables:
// Names in the list fObsNameVec:
RooArgList theObservables;
std::vector<std::string>::iterator itr = fObsNameVec.begin();
for (int idx=0; itr!=fObsNameVec.end(); ++itr, ++idx ) {
theObservables.add( *proto.var(*itr) );
for (const auto &obsName : fObsNameVec) {
theObservables.add( *proto.var(obsName) );
}

// Create the list of terms to
Expand Down
Loading