Pass DefinePerSample column to varied actions on request#22368
Open
vepadulano wants to merge 1 commit into
Open
Pass DefinePerSample column to varied actions on request#22368vepadulano wants to merge 1 commit into
vepadulano wants to merge 1 commit into
Conversation
A varied action will be looking for column readers through its current variation name. In the case of an upstream Define, the node will return the correct reader based on the variation. In the case of an upstream DefinePerSample, given it can't depend on variations and it can't vary itself, we now return just the node itself. Fixes root-project#22367
Test Results 20 files 20 suites 3d 2h 16m 28s ⏱️ For more details on these failures, see this check. Results for commit dabd77b. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A varied action will be looking for column readers through its current variation name. In the case of an upstream Define, the node will return the correct reader based on the variation. In the case of an upstream DefinePerSample, given it can't depend on variations and it can't vary itself, we now return just the node itself.
Fixes #22367