[HS3] Add parameter errors in HS3 JSON import/export#22405
Merged
Conversation
Test Results 21 files 21 suites 3d 6h 57m 15s ⏱️ Results for commit 5897165. ♻️ This comment has been updated with latest results. |
guitargeek
requested changes
Jun 11, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
The changes look good to me!
The commit history: not yet. Extra commits that just reformat the code additions of previous commits are unnecessary noise. Could you please squash the clang-format commit with the commit that added this RooJSONFactoryWSTool::warning?
Phmonski
force-pushed
the
feat/parameterErrors
branch
from
e91e139 to
5897165
Compare
Contributor
Author
|
@guitargeek |
Contributor
|
/backport to 6.40 |
|
Preparing to backport PR #22405 to branch 6.40 requested by guitargeek |
|
This PR has been backported to branch 6.40: #22585 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
This PR adds support for exporting and importing RooRealVar parameter errors through HS3 JSON. Parameter uncertainties are written to misc.minimization.parameter_stepwidths and restored during import after the default parameter snapshot is loaded.
Changes or fixes:
The export logic collects relevant parameters from ModelConfig POI/nuisance sets and from PDF/data fallback discovery, while excluding observables and data axes. The PR also adds regression coverage for parameter-error round-tripping, data-axis exclusion, and preserving imported errors together with default snapshot values.
Checklist:
@will-cern @cburgard