[math] Drop R interface from stressGoFTest#22446
Merged
Merged
Conversation
The `#ifdef ROOT_HAS_R` blocks in UnitTest3/4/5 used the R interface at runtime to overwrite the hardcoded expected A2 and Dn values with freshly computed ones. The hardcoded values already match what R produces on the same generated sample, so this added a build-time dependency on the R interface (and the `-DROOT_HAS_R` define) for no real benefit. Remove the runtime R calls, the `TRInterface.h` include and the private `R_ADTest` / `R_KSTest` helpers. Each hardcoded reference value now carries an inline `// R: ...` comment quoting the exact `ad.test` / `ks.test` call it was derived from, and the file header documents how to reproduce them by dumping the sample and running R on it. Also drop the now-unused `if(r)` block from the test CMakeLists, since no other test in this directory uses the R interface. This is done in proparation to removing the deprecated R interface.
Test Results 22 files 22 suites 3d 13h 31m 47s ⏱️ Results for commit 54ed364. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
#ifdef ROOT_HAS_Rblocks in UnitTest3/4/5 used the R interface at runtime to overwrite the hardcoded expected A2 and Dn values with freshly computed ones. The hardcoded values already match what R produces on the same generated sample, so this added a build-time dependency on the R interface (and the-DROOT_HAS_Rdefine) for no real benefit.Remove the runtime R calls, the
TRInterface.hinclude and the privateR_ADTest/R_KSTesthelpers. Each hardcoded reference value now carries an inline// R: ...comment quoting the exactad.test/ks.testcall it was derived from, and the file header documents how to reproduce them by dumping the sample and running R on it.Also drop the now-unused
if(r)block from the test CMakeLists, since no other test in this directory uses the R interface.This is done in proparation to removing the deprecated R interface.