[ntuple] Add S3 anchor and its tests for S3 backend#22470
Merged
Conversation
JasMehta08
force-pushed
the
ntuple-s3-anchor
branch
from
9a87143 to
3a8cec6
Compare
Contributor
Author
|
I have made the changes so that the build for S3 backend only occurs when curl is present, and removed the s3 flag. |
jblomer
reviewed
Jun 9, 2026
Test Results 22 files 22 suites 3d 12h 13m 20s ⏱️ For more details on these failures, see this check. Results for commit bdfbf14. ♻️ This comment has been updated with latest results. |
JasMehta08
force-pushed
the
ntuple-s3-anchor
branch
2 times, most recently
from
77b7180 to
7a7616f
Compare
Contributor
Author
|
I have made the update according to the comments |
jblomer
approved these changes
Jun 11, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
LGTM (but see the clang-format report)
JasMehta08
force-pushed
the
ntuple-s3-anchor
branch
from
7a7616f to
a682e70
Compare
Contributor
Author
|
I have made the change in the small comment which had issue with Clang format |
JasMehta08
force-pushed
the
ntuple-s3-anchor
branch
from
a682e70 to
bdfbf14
Compare
Contributor
Author
|
Please have a review and let me know if there are any changes remaining, Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
(Is a part of the GSoC 2026 project
S3 Backend for RNTuple.)Creates the anchor for the S3 backend.
Changes or fixes:
S3NTupleAnchorstruct, using JSON to store the anchor data.ROOT_BUILD_OPTION(s3 OFF "Enable RNTuple support for S3-compatible object storage")to conditionally compile.Checklist: