Skip to content

[nfc][6.40] Fix description of builtin build options#22730

Merged
dpiparo merged 1 commit into
root-project:v6-40-00-patchesfrom
ferdymercury:bops640
Jun 30, 2026
Merged

[nfc][6.40] Fix description of builtin build options#22730
dpiparo merged 1 commit into
root-project:v6-40-00-patchesfrom
ferdymercury:bops640

Conversation

@ferdymercury

Copy link
Copy Markdown
Collaborator

No description provided.

@ferdymercury ferdymercury requested a review from bellenot as a code owner June 30, 2026 06:24
@dpiparo dpiparo added the skip ci Skip the full builds on the actions runners label Jun 30, 2026
@github-actions

Copy link
Copy Markdown

Test Results

2 613 tests   2 613 ✅  1h 23m 45s ⏱️
    2 suites      0 💤
    2 files        0 ❌

Results for commit f430c98.

@dpiparo

dpiparo commented Jun 30, 2026

Copy link
Copy Markdown
Member

Thanks for this PR, which is a clear improvement. I am not sure about the word internally: perhaps something like

  • from an external builtin package
  • from external source code
  • from an externally provided source tarball (maybe the most accurate?)

Maybe adding something like "for backwards compatibility", too?

@ferdymercury

ferdymercury commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for the review!

Wrt "internally": I copy-pasted the wording from other builtins such as openssl or xrootd.
Wrt "for backward compatibility": maybe not needed since we already have the warning in ROOT_FIND_REQUIRED_DEP macro?

Since this is a patch for 6.40, should we maybe reword all of them instead just in this master-PR ? #21596 and leave this one as-is ?

@dpiparo

dpiparo commented Jun 30, 2026

Copy link
Copy Markdown
Member

--> Yes, my bad.

@dpiparo dpiparo merged commit 4485209 into root-project:v6-40-00-patches Jun 30, 2026
16 of 37 checks passed
@ferdymercury ferdymercury deleted the bops640 branch June 30, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip ci Skip the full builds on the actions runners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants