Remove gVirtualX usage in TGaxis and TView3D#22737
Merged
Merged
Conversation
Two methods were used: 1. gVirtualX->SetClipOFF(), which is not necessary while no any places in ROOT where ClipRegion is configured 2. gVirtualX->SetCharacterUp() which was used long time agi to define text rotation angle. It is obsolete while direct text painting with gVirtualX methods no longer usead and textaxis.PaintLatex() always specify angle. This change allows to paint axes and all histograms on qt6 canvas.
In one place line attributes were reset. Now pad painter is responsible for attributes - use it. Allow to use lego plots with qt6 canvas
couet
approved these changes
Jul 1, 2026
Test Results 23 files 23 suites 3d 16h 17m 27s ⏱️ For more details on these failures, see this check. Results for commit 979e03d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In TGaxis gVirtualX was used to set text angle - which is not obsolete and ignored when axistext.PaintLatex() method is used. Also gVirtualX clipping is not used in ROOT, therefore no need to disable it.
In TView3D only line attributes of gVirtualX were reset. Now it is mostly useless, but just replace with similar pad painter method.
Both commits allow to use
TQt6Canvasfrom #22736 for all kinds of histogram painting