Fix in complex_quartic problem reported in issue #6900 and add test #6908
Conversation
…d add test Uncomment some different code that is used to compute the discriminat of the resolvent cubic equation used to find roots of quartic. This code seems to eprforms better. This fixes root-project#6900 Add tests for quartic equations
…OOT::Math::Polynomial
lmoneta
force-pushed
the
fix_polynomial_quartic_solver
branch
from
de9d345 to
1e905fa
Compare
|
@phsft-bot build just on ROOT-debian10-i386/cxx14 with flags -Dmathmore=On |
|
@phsft-bot build |
guitargeek
requested review from
guitargeek
and removed request for
oshadura
|
@phsft-bot build with flags -Dmathmore=On |
|
Starting build on |
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
This is a nice improvement! Maybe we can still merge it, and also close the associated issue?
|
Build failed on windows10/default. Errors:
|
|
Build failed on ROOT-ubuntu2204/nortcxxmod. Failing tests: |
|
@guitargeek @lmoneta before merging such old PR, it would have been in order to rebase and run this through the new CI: It broke Windows builds (fixed by @bellenot in #14274) and causes a CMake warning (to be addressed by #14280)... |
|
The new test also seems to fail on mac14arm in the new CI, can you please have a look asap? @guitargeek @lmoneta (edit: fix proposed in #14291) |
…d add test (root-project#6908) * Fix in complex_quartic problem reported in issue root-project#6900 and add test Uncomment some different code that is used to compute the discriminat of the resolvent cubic equation used to find roots of quartic. This code seems to eprforms better. This fixes root-project#6900 Add tests for quartic equations * Update and fix links and spelling in the reference documentation of ROOT::Math::Polynomial * Increate test tolerance for fixing failure observed in i386
…d add test (root-project#6908) * Fix in complex_quartic problem reported in issue root-project#6900 and add test Uncomment some different code that is used to compute the discriminat of the resolvent cubic equation used to find roots of quartic. This code seems to eprforms better. This fixes root-project#6900 Add tests for quartic equations * Update and fix links and spelling in the reference documentation of ROOT::Math::Polynomial * Increate test tolerance for fixing failure observed in i386
4 participants
Uncomment some different code that is used to compute the discriminat of the
resolvent cubic equation used to find the roots of a quartic equation.
This different code seems to be better numerically.
This fixes #6900
Add tests for quartic equations to validate code.