Skip to content

Allows to configure CUDA sm level for Cling CUDA tests #7190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vgvassilev merged 1 commit into from
Feb 18, 2021
Merged

Allows to configure CUDA sm level for Cling CUDA tests #7190

vgvassilev merged 1 commit into from
Feb 18, 2021

Conversation

@SimeonEhrig
Copy link
Contributor

@SimeonEhrig SimeonEhrig commented Feb 12, 2021

  • the CUDA sm level can be set via CLING_TEST_CUDA_SM_LEVEL environment variable (e.g. "35"), before running the tests
  • this necessary, because the minimum sm level depends on the use CUDA SDK
  • for example, CUDA 8.0 supports sm level 2.0, which is not support from CUDA 10.1 anymore

@SimeonEhrig
Allows to configure CUDA sm level for Cling CUDA tests
bf9a463 
- the CUDA sm level can be set via CLING_TEST_CUDA_SM_LEVEL
environment variable (e.g. "35"), before running the tests
@phsft-bot
Copy link

phsft-bot commented Feb 12, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

phsft-bot commented Feb 12, 2021

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

  • [2021-02-12T11:26:00.102Z] C:\build\workspace\root-pullrequests-build\build\bin\libGdml.dll : fatal error LNK1120: 1 unresolved externals [C:\build\workspace\root-pullrequests-build\build\geom\gdml\Gdml.vcxproj]

@SimeonEhrig
Copy link
Contributor Author

SimeonEhrig commented Feb 18, 2021

@vgvassilev Can you please review the PR?

vgvassilev
vgvassilev approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cc: @davidlange6

@vgvassilev
Copy link
Member

vgvassilev commented Feb 18, 2021

The windows failure seems unrelated to the changes.

@vgvassilev vgvassilev merged commit d1e0f2b into root-project:master Feb 18, 2021
@SimeonEhrig
Copy link
Contributor Author

SimeonEhrig commented Feb 18, 2021

The windows failure seems unrelated to the changes.
Yes Axel also mentioned is this PR, that is unrelated: #6707 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vgvassilev vgvassilev vgvassilev approved these changes

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann

Assignees

@Axel-Naumann Axel-Naumann

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SimeonEhrig @phsft-bot @vgvassilev @Axel-Naumann