Closed
Conversation
perovic
changed the title
perovic
force-pushed
the
master
branch
3 times, most recently
from
26d4321 to
167da58
Compare
Member
There was a problem hiding this comment.
Could you re-implement the string_view overload in a next revision?
Contributor
Author
There was a problem hiding this comment.
Will do. I put it in TString.h again, as the required header is not included in RuntimePrintValue.h. Let me know if I should move it there. Thanks!
Contributor
Author
There was a problem hiding this comment.
Indeed - std::ostringstream prints void pointers as, for example, "0x12dab47b".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1st commit: Do not randomly add to lookup results during
EvaluateT()Axel fixed the notorious bug which prevented having templated
printValue()functions in the "RuntimePrintValue.h" header which is declared programmatically on the firstprintValue()invocation. Runtime resolving of some identifiers was used when it shouldn't be. Moving the checking of this condition to the beginning of the function fixed the issue.2nd commit: Removed old
printValuefrom TDatime and TString3rd commit: New
printValueintegration4th commit: Re-added
printValuefunctionality to TString and TDatime5th, final commit: Minor fix