[GSoC][TMVA][SOFIE] Modified AddOutputTensorNameList in RModel #8640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjibansg
requested review from
ashlaban,
lmoneta,
sitongan and
stwunsch
as code owners
|
Can one of the admins verify this patch? |
sitongan
suggested changes
Jul 12, 2021
Contributor
sitongan
left a comment
sitongan
left a comment
There was a problem hiding this comment.
Hi @sanjibansg thanks for the PR. Could you put the code in the RModel cxx file instead, thanks!
Contributor
Author
Hi @sitongan |
sitongan
approved these changes
Jul 12, 2021
Contributor
sitongan
left a comment
sitongan
left a comment
There was a problem hiding this comment.
LGTM!
Note to future: an output tensor as in ONNX definition will also be considered an IntermediateTensor here. Its memory allocation is handled when intemdiate tensors are allocated. We keep track of output tensor just to identify the final output of the model graph.
pzhristov
pushed a commit
to alisw/root
that referenced
this pull request
Aug 27, 2021
…project#8640) * Modified AddOutputTensorNameList in RModel * Function definition of AddOutputTensorNameList() moved to RModel.cxx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the AddOutputTensorNameList() function present in RModel.hxx to use the UTILITY::Clean_name() function to process the strings before adding them into the RModel.
Checklist: