Skip to content

[GSoC][TMVA][SOFIE] Add BatchNormalization operator#8882

Closed
AaradhyaSaxena wants to merge 3 commits intoroot-project:masterfrom
AaradhyaSaxena:master
Closed

[GSoC][TMVA][SOFIE] Add BatchNormalization operator#8882
AaradhyaSaxena wants to merge 3 commits intoroot-project:masterfrom
AaradhyaSaxena:master

Conversation

@AaradhyaSaxena
Copy link
Copy Markdown
Contributor

This Pull request:

Development of the BatchNormalization operator for the Google Summer of Code 2021 project Inference Code Generation for Batch Normalization.

Checklist:

  • [ x] tested changes locally

@phsft-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@lmoneta
Copy link
Copy Markdown
Member

lmoneta commented Aug 23, 2021

@phsft-bot build just on ROOT-ubuntu2004/default with flags -Dtmva-sofie=On

@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-ubuntu2004/default with flags -Dtmva-sofie=On
How to customize builds

@phsft-bot
Copy link
Copy Markdown

Build failed on ROOT-ubuntu2004/default.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

  • [2021-08-23T16:06:16.709Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie_parsers/src/RModelParser_ONNX.cxx:252:20: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
  • [2021-08-23T16:06:16.709Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie_parsers/src/RModelParser_ONNX.cxx:217:120: warning: unused parameter ‘graphproto’ [-Wunused-parameter]
  • [2021-08-23T16:08:04.901Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie_parsers/src/RModelParser_ONNX.cxx:252:20: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
  • [2021-08-23T16:08:04.901Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie_parsers/src/RModelParser_ONNX.cxx:217:120: warning: unused parameter ‘graphproto’ [-Wunused-parameter]
  • [2021-08-23T16:08:06.343Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie_parsers/src/RModelParser_ONNX.cxx:252:20: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
  • [2021-08-23T16:08:06.343Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie_parsers/src/RModelParser_ONNX.cxx:217:120: warning: unused parameter ‘graphproto’ [-Wunused-parameter]
  • [2021-08-23T16:08:06.679Z] /usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:33: warning: ‘void* _builtin_memset(void*, int, long unsigned int)’ offset [25, 32] from the object at ‘onnx::TensorProto_Segment_default_instance’ is out of the bounds of referenced subobject ‘onnx::TensorProto_Segment::begin’ with type ‘long int’ at offset 16 [-Warray-bounds]
  • [2021-08-23T16:08:06.679Z] /usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:33: warning: ‘void* _builtin_memset(void*, int, long unsigned int)’ offset [25, 28] from the object at ‘onnx::TypeProto_Tensor_default_instance’ is out of the bounds of referenced subobject ‘onnx::TypeProto_Tensor::shape’ with type ‘onnx::TensorShapeProto*’ at offset 16 [-Warray-bounds]
  • [2021-08-23T16:08:06.679Z] /usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:33: warning: ‘void* _builtin_memset(void*, int, long unsigned int)’ offset [25, 28] from the object at ‘onnx::TypeProto_Map_default_instance’ is out of the bounds of referenced subobject ‘onnx::TypeProto_Map::value_type’ with type ‘onnx::TypeProto*’ at offset 16 [-Warray-bounds]
  • [2021-08-23T16:08:06.679Z] /usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:33: warning: ‘void* _builtin_memset(void*, int, long unsigned int)’ offset [49, 56] from the object at ‘onnx::SparseTensorProto_default_instance’ is out of the bounds of referenced subobject ‘onnx::SparseTensorProto::values’ with type ‘onnx::TensorProto*’ at offset 40 [-Warray-bounds]

And 6 more

Copy link
Copy Markdown
Member

@lmoneta lmoneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AaradhyaSaxena
Thank you for this useful contribution!
Can you please add also a test program for the Batch Normalisation in tmva/sofie/test ?

@AaradhyaSaxena
Copy link
Copy Markdown
Contributor Author

Hi @AaradhyaSaxena
Thank you for this useful contribution!
Can you please add also a test program for the Batch Normalisation in tmva/sofie/test ?

@lmoneta, I will add the test program asap.

@lmoneta
Copy link
Copy Markdown
Member

lmoneta commented Nov 17, 2021

This PR is replaced by #9307 , that includes the commits of this PR and extends it adding the test program

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants