Skip to content

point to full list of compilation options#773

Merged
eguiraud merged 2 commits intoroot-project:mainfrom
ferdymercury:patch-2
Apr 20, 2022
Merged

point to full list of compilation options#773
eguiraud merged 2 commits intoroot-project:mainfrom
ferdymercury:patch-2

Conversation

@ferdymercury
Copy link
Contributor

and clarify some alternatives more explicitly

and clarify some alternatives more explicitly
@couet couet requested review from couet and guitargeek March 17, 2022 06:19
Copy link
Member

@couet couet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@couet couet requested review from couet and guitargeek and removed request for guitargeek March 17, 2022 06:23
@couet couet self-requested a review March 17, 2022 06:25
@ferdymercury
Copy link
Contributor Author

(This one's ready too from my side)

Co-authored-by: Enrico Guiraud <enrico.guiraud@cern.ch>
Copy link
Member

@couet couet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If it is fine for @eguiraud (who did some comments), I think we can merge.

@couet couet self-requested a review March 21, 2022 09:17
@ferdymercury ferdymercury mentioned this pull request Apr 7, 2022
@ferdymercury
Copy link
Contributor Author

LGTM. If it is fine for @eguiraud (who did some comments), I think we can merge.

egiraud approved, I think this one is ready to merge. Thanks!

@eguiraud eguiraud merged commit eb45c79 into root-project:main Apr 20, 2022
@ferdymercury ferdymercury deleted the patch-2 branch April 20, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants