Conversation
vizsatiz
reviewed
Sep 13, 2024
Member
vizsatiz
left a comment
vizsatiz
left a comment
There was a problem hiding this comment.
I will add more comments later
vizsatiz
requested changes
Sep 17, 2024
vizsatiz
previously approved these changes
Sep 17, 2024
vizsatiz
reviewed
Sep 18, 2024
|
|
||
| FLO_LOG_LEVEL_COMMON: Controls the level for the "CommonLogs" logger. | ||
| FLO_LOG_LEVEL_BUILDER: Controls the level for the "BuilderLogs" logger. | ||
| FLO_LOG_LEVEL_SESSION: Controls the level for the "SessionLogs" logger. |
Member
There was a problem hiding this comment.
Maybe we can add the definition of what commonlogs, builderlogs and sessionlogs are in this readme
| export FLO_LOG_LEVEL_SESSION=WARNING | ||
|
|
||
|
|
||
| 2. FloSession Creation: |
| @@ -0,0 +1,67 @@ | |||
| # Understanding Log Levels | |||
Member
There was a problem hiding this comment.
You can probably copy paste this to an AI prompt and make it better markdown
Member
There was a problem hiding this comment.
Remove this file, add the *.log in .gitignore
| def build(session: FloSession, yaml: str): | ||
| return Flo(session, to_supervised_team(yaml)) | ||
| def build(session: FloSession, yaml: str, log_level: str = "INFO"): | ||
| FloLogger.set_log_level("BUILDER", log_level) |
| from langchain.schema import AgentAction, AgentFinish, LLMResult | ||
| from flo_ai.common.flo_logger import get_logger | ||
|
|
||
| class FloCallbackHandler(BaseCallbackHandler): |
Member
There was a problem hiding this comment.
Why do we have both this and langchain handler ?
Member
|
@thomastomy5 Overall the design is really good! |
vizsatiz
reviewed
Sep 18, 2024
| self.runnable: ExecutableFlo = build_supervised_team(session, config) | ||
|
|
||
| FloLogger.set_log_level("COMMON", log_level) | ||
| FloLogger.set_log_level("BUILDER", log_level) |
Member
There was a problem hiding this comment.
Why dont you use set_global_log_level?
vizsatiz
approved these changes
Sep 21, 2024
thomastomy5
added a commit
that referenced
this pull request
Apr 27, 2026
* added logging to Flo library * added sessionid and option for custom logger * created common set of loggers and included readmefile for logging * updated README and changed the config updation location to core * Minor fixes before merging * Minor fixes around logging * Fix for notebooks * Final fixes to log levels --------- Co-authored-by: vizsatiz <satis.vishnu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.