port/builtin: RemovePort() block until conn is closed, take 2 + Release v0.14.4#265
Merged
AkihiroSuda merged 4 commits intorootless-containers:masterfrom Aug 4, 2021
Merged
Conversation
This reverts commit 72fdd24. `routineStopCh <- struct{}{}` in `parent.go` can be delivered to the `copyConnToChild(c, socketPath, spec, stopCh)` routine in `tcp.go`, so this does not work as expected and has to be reverted. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Alternative to reverted PR 262 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
changed the title
Contributor
|
Thanks @AkihiroSuda, sorry for missing that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #262 (https://github.com/rootless-containers/rootlesskit/pull/262/files#r682338302) and add an alternative.