Logs command: add VM support #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #511 Automatic support for `trellis logs development` with dev virtual machines (Lima). Instead of hardcoding assumptions of ssh, this detects VM usage and uses the `vm.Manager` interface to run commands directly on the VM. In Lima's case, it uses `limactl shell` under the hood.
swalkinshaw
force-pushed
the
logs-vm-support
branch
from
af59eda to
1bb8779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #511
Automatic support for
trellis logs developmentwith dev virtual machines (Lima). Instead of hardcoding assumptions of ssh, this detects VM usage and uses thevm.Managerinterface to run commands directly on the VM. In Lima's case, it useslimactl shellunder the hood.