Merged
Conversation
retlehs
approved these changes
Mar 24, 2026
Member
retlehs
left a comment
There was a problem hiding this comment.
Thanks for finding this and for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds .mjs to the default SUPPORTED_EXTENSIONS. Wordpress packages like @wordpress/icons switched to .mjs for their builds in a recent version.
The plugin's transform hook skips .mjs files, so the @wordpress/primitives imports inside @wordpress/icons are never rewritten to use wp.primitives globals.
The problem can easily be replicated using a fresh Radicle project because @wordpress/icons is used in a few of the included blocks. Without adding .mjs as a supported extension the browser fails with:
Because wordpress packages seem to be moving to using .mjs extensions, I thought this would be a helpful default, but this can also be easily solved at the project level by adding the extension to the
vite.config.js