Fix/wordpress jsx runtime#44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Projects using
wordpressPlugin()with JSX block files fail to build under Vite 8 with:Oxc defaults to React's automatic JSX runtime and injects
import { jsx as _jsx } from 'react/jsx-runtime'into every JSX file. WordPress block projects don't installreact— they rely onwp.element— so this import can't be resolved and the build fails with a hard error.Context
I ran into this while upgrading a Sage project that includes a lot of jsx blocks in the theme, similar to what Radicle does. I was very confused because another project using the most recent version of Radicle doesn't have this issue. It turns out this issue was masked in Radicle because react gets pulled in by
@wordpress/icons.What this PR does
Adds a
config()hook towordpressPluginthat switches the JSX transform to classic mode and points it atwp.element:runtime: 'classic'disables the automatic JSX runtime import.pragmaandpragmaFragpoint JSX calls atwp.element.createElementandwp.element.Fragment, which are provided globally by WordPress.Three new options are also added to
WordPressPluginConfigfor projects that need to override the defaults:Happy to pull out this config override option if it seems unlikely to be used.
Also, although this seems like a sensible default, an alternative to this PR would be adding something like this to the vite config of each project:
**Debugged with a lot of help from Claude