Tags Invalid with VersionParser.php

[rvola]

Version

production

What did you expect to happen?

Some tags should not be taken into account because they cause Composer's version parser to malfunction.
Example: wp-plugin/elementor

https://wp-composer.com/packages/wp-plugin/elementor

What actually happens?

Unable to install or update

In VersionParser.php line 191:
                                       
  Invalid version string "3.1.0-dev1"  

Steps to reproduce

composer.json example :

{
    "name": "rvola/test",
    "repositories": [{
        "name": "wp-composer",
        "type": "composer",
        "url": "https://repo.wp-composer.com"
    }],
    "require": {
        "wp-plugin/elementor"
    }
}

System info

No response

Log output

Please confirm this isn't a support request.

Yes

[tangrufus]

Here are more invalid version examples found in WordPress plugins and themes: https://github.com/typisttech/comver/blob/ebd0706326f20be77d1192ba2a21e36903001e62/internal/wordfencetest/version_test.go#L10

[rvola]

I would like to clarify that I am not trying to install version 3.1.0-dev1, but simply the latest version of Composer.
However, the installation fails during the analysis of the package.json file

[rvola]

[tangrufus]

Agree we should reject non-compliant versions.

To @retlehs

Maybe composer-semver or comver could help?

[retlehs]

@rvola Thanks for the report! About to push a PR for this fix

@tangrufus Will look into https://github.com/typisttech/composer-semver as a follow-up

[retlehs]

@rvola Elementor is fixed ✅ along with the other affected packages