Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s module-tidiness checks to use go mod tidy -diff, aligning local linting and CI with a non-mutating, diff-based verification approach.
Changes:
- Replace the Makefile
linttarget’sgo mod tidy+git diffcheck withgo mod tidy -diff. - Simplify the CI “Go Modules Tidy” job to run
go mod tidy -diffdirectly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Makefile | Uses go mod tidy -diff during make lint instead of modifying files and then checking git diff. |
| .github/workflows/ci.yml | Replaces the inline shell script for tidiness checking with go mod tidy -diff. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @if [ -n "$$(gofmt -s -l .)" ]; then echo "gofmt needed:"; gofmt -s -l .; exit 1; fi | ||
| go vet ./... | ||
| @go mod tidy && if [ -n "$$(git diff --name-only -- go.mod go.sum)" ]; then echo "go mod tidy needed"; exit 1; fi | ||
| go mod tidy -diff |
| git diff -- go.mod go.sum | ||
| exit 1 | ||
| fi | ||
| run: go mod tidy -diff |
Member
There was a problem hiding this comment.
🤷♂️ I don't mind either way
swalkinshaw
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.