Merged
Conversation
Under heavy crawler traffic, unbounded OG generation goroutines were constantly contesting the SQLite write lock, starving the pipeline. Non-blocking semaphore skips generation when at capacity — the image will be generated on the next visit instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Acquiring the semaphore before spawning the goroutine ensures excess requests under crawler spikes don't create unbounded goroutines that immediately exit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
Wrap |
Member
Author
|
Thank you, will take a peek tomorrow or sometime soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go generatePackageOG()goroutineswere constantly contesting the SQLite write lock, causing the pipeline to
fail with
SQLITE_BUSYinstead of queuing, so the image gets generated on the next page visit
pipeline failures from OG lock contention
Test plan
make testpasses🤖 Generated with Claude Code