Move OG image generation from request handler to pipeline#48
Open
swalkinshaw wants to merge 1 commit intomainfrom
Open
Move OG image generation from request handler to pipeline#48swalkinshaw wants to merge 1 commit intomainfrom
swalkinshaw wants to merge 1 commit intomainfrom
Conversation
Remove on-demand OG generation from the HTTP handler to eliminate SQLite write contention under crawler traffic. New packages get their OG images generated during the pipeline run (after build, before deploy). The daily batch job continues to handle regeneration when install counts change. - Remove ogSem semaphore and generatePackageOG from handlers - Add GenerateNew() for first-time OG generation only - Add ImageRenderer function type for testability - Fix SQLite deadlock: collect rows before writing (open cursor + write) - Unexport internal helpers (markOGGenerated, getPackagesNeedingOG) - Remove unused MarkOGGeneratedBySlug Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
@tangrufus alternative to semaphore and rate limiting since we shouldn't even expose the on-demand image generation imo. This does it all at build time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove on-demand OG generation from the HTTP handler to eliminate SQLite write contention under crawler traffic. New packages get their OG images generated during the pipeline run (after build, before deploy). The daily batch job continues to handle regeneration when install counts change.