fix: safe hashes script execution#96
Merged
bernacodesido merged 2 commits intorootstockfrom Jun 24, 2025
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the safe hashes script execution and improves error handling across various components.
- Updates test expectations and error handling for safe hash parsing.
- Refines API types and notification messages for safe transaction hashes.
- Adds retry logic and enhanced timeouts in the safe hashes execution script.
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/SafeWatcher.test.ts | Updated tests to expect error objects with error messages |
| src/types.ts | Extended types for safe hashes to include TxHashError |
| src/safe-hashes/schema.ts | Added TxHashError interface |
| src/safe-hashes/Safetxhashes.ts | Introduced retry logic and improved timeout handling for script execution |
| src/notifications/Telegram.ts | Updated notification sender to accept union type for safe hashes |
| src/notifications/Slack.ts | Refined Slack message formatting for error handling in safe hashes |
| src/notifications/NotificationSender.ts | Changed argument types to include TxHashError |
| src/SafeWatcher.ts | Updated safe hash processing with more robust error handling |
| package.json | Added file for test coverage |
| Dockerfile | Installed additional dependencies for enhanced shell compatibility |
| return parseResponse(safeTxHashesResult.data); | ||
| } catch (error) { | ||
| this.#logger.error({ error }, "Failed to parse SafeTxHashes response"); | ||
| return { message: "Failed to parse SafeTxHahes response" }; |
There was a problem hiding this comment.
The error message contains a typo 'SafeTxHahes' which should be corrected to 'SafeTxHashes' for consistency.
Suggested change
| return { message: "Failed to parse SafeTxHahes response" }; | |
| return { message: "Failed to parse SafeTxHashes response" }; |
VaWheel
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the safe hashes script execution
handle errors