Conversation
Merge dev to staging: Fix search to work on the org page
Merge staging to prod: Fix search to work on the org page
Merge dev to staging: Bluesky text update
Merge staging yo prod: Bluesky text update
Contributor
|
@kaysiz I did some testing, and it looks like some of the validation listed in the spec is not included https://docs.google.com/document/d/1odIr-LcjJ-hh7HP8RphReCvCL14iMEJLFM23X1vWv-0/edit?tab=t.0#heading=h.9wkd2a7lfe5s Specific items to take a look at are:
Additionally:
|
Contributor
|
@kaysiz Almost there! Validation is looking good. A few tiny label tweaks:
I'm still having a heck of a time entering an institution name that is not in the ROR typeahead and have not been able to successfully add a manually-entered org name. Specifically:
Screen.Recording.2025-03-28.at.9.36.14.AM.mov |
Contributor
|
Looks good! Just waiting on the last bit about empty string vs null values for institution ROR and country code, as discussed on Slack. |
lizkrznarich
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.