test(config): sync tui_config test with new GeneralConfig fields#55
Merged
Conversation
The GeneralConfig struct gained shell_integration and desktop_notifications fields, but the tui_config test lagged behind: the struct literal omitted both fields (E0063) and field_index_sanity asserted 39 F_* slots against the real 41. Add the missing fields to the literal and the two constants to the occupied vec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing CI Test job (run 28412896150).
GeneralConfiggained two fields (shell_integration,desktop_notifications) and the production code was fully wired, but thetui_configtest lagged behind in two places:GeneralConfig { ... }struct literal omitted both fields →error[E0063], blocking the whole test build.field_index_sanityasserted 39F_*slots against the real 41 fields.This adds the missing fields to the literal and the two constants (
F_SHELL_INTEGRATION,F_DESKTOP_NOTIFICATIONS) to theoccupiedvec.Verification
cargo fmt --check— cleancargo clippy --locked -- -D warnings— cleancargo test --locked— 1191 passing