Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 19, 2025

This PR includes the following changes:

  • Renamed the Odometry class to SteeringKinematics to better represent its support for both FK and IK.
  • Added deprecation warnings in the old steering_odometry.hpp header file to maintain backward compatibility.
  • Kept the steering_odometry.cpp for backward compatibility and redirected actual implementation to steering_odometry.cpp
  • Updated comments in the header file to reflect the new class name.
    This is an automatic backport of pull request Rename Odometry Class to SteeringKinematics #1996 done by Mergify.

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 81.17647% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.46%. Comparing base (03e4ec7) to head (ae22704).
⚠️ Report is 2 commits behind head on jazzy.

Files with missing lines Patch % Lines
...ng_controllers_library/src/steering_kinematics.cpp 83.42% 28 Missing and 1 partial ⚠️
...ring_controllers_library/src/steering_odometry.cpp 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2013      +/-   ##
==========================================
- Coverage   84.67%   84.46%   -0.21%     
==========================================
  Files         138      139       +1     
  Lines       13425    13457      +32     
  Branches     1199     1199              
==========================================
  Hits        11367    11367              
- Misses       1645     1677      +32     
  Partials      413      413              
Flag Coverage Δ
unittests 84.46% <81.17%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...g_controller/src/ackermann_steering_controller.cpp 54.38% <100.00%> (ø)
...ing_controller/src/bicycle_steering_controller.cpp 62.50% <100.00%> (ø)
...eering_controllers_library/steering_kinematics.hpp 100.00% <100.00%> (ø)
...llers_library/src/steering_controllers_library.cpp 64.01% <100.00%> (ø)
...library/test/test_steering_controllers_library.hpp 97.22% <100.00%> (ø)
...ontrollers_library/test/test_steering_odometry.cpp 100.00% <100.00%> (ø)
...ng_controller/src/tricycle_steering_controller.cpp 62.79% <100.00%> (ø)
...ring_controllers_library/src/steering_odometry.cpp 0.00% <0.00%> (-83.43%) ⬇️
...ng_controllers_library/src/steering_kinematics.cpp 83.42% <83.42%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit dc8a272 into jazzy Nov 19, 2025
14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/jazzy/pr-1996 branch November 19, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants