Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 19, 2025

This PR includes the following changes:

  • Renamed the Odometry class to SteeringKinematics to better represent its support for both FK and IK.
  • Added deprecation warnings in the old steering_odometry.hpp header file to maintain backward compatibility.
  • Kept the steering_odometry.cpp for backward compatibility and redirected actual implementation to steering_odometry.cpp
  • Updated comments in the header file to reflect the new class name.
    This is an automatic backport of pull request Rename Odometry Class to SteeringKinematics #1996 done by Mergify.

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 81.17647% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.13%. Comparing base (fc5314c) to head (549c5c9).
⚠️ Report is 2 commits behind head on kilted.

Files with missing lines Patch % Lines
...ng_controllers_library/src/steering_kinematics.cpp 83.42% 28 Missing and 1 partial ⚠️
...ring_controllers_library/src/steering_odometry.cpp 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           kilted    #2014      +/-   ##
==========================================
- Coverage   85.32%   85.13%   -0.20%     
==========================================
  Files         143      144       +1     
  Lines       13936    13968      +32     
  Branches     1201     1201              
==========================================
  Hits        11891    11891              
- Misses       1638     1670      +32     
  Partials      407      407              
Flag Coverage Δ
unittests 85.13% <81.17%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...g_controller/src/ackermann_steering_controller.cpp 81.57% <100.00%> (ø)
...ing_controller/src/bicycle_steering_controller.cpp 76.92% <100.00%> (ø)
...eering_controllers_library/steering_kinematics.hpp 100.00% <100.00%> (ø)
...llers_library/src/steering_controllers_library.cpp 68.40% <100.00%> (ø)
...library/test/test_steering_controllers_library.hpp 97.43% <100.00%> (ø)
...ontrollers_library/test/test_steering_odometry.cpp 100.00% <100.00%> (ø)
...ng_controller/src/tricycle_steering_controller.cpp 81.25% <100.00%> (ø)
...ring_controllers_library/src/steering_odometry.cpp 0.00% <0.00%> (-83.43%) ⬇️
...ng_controllers_library/src/steering_kinematics.cpp 83.42% <83.42%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 82bdf08 into kilted Nov 19, 2025
14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/kilted/pr-1996 branch November 19, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants