moveit::core::isEmpty #1627
Merged
moveit::core::isEmpty #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4hn
requested review from
BryceStevenWilley,
IanTheEngineer,
jonbinney,
mlautman and
rhaschke
as code owners
v4hn
force-pushed
the
pr-master-isempty-in-utils
branch
from
b302bce
to
a133202
Compare
|
I rebased the request. |
jschleicher
added a commit
to PilzDE/pilz_industrial_motion
that referenced
this pull request
Oct 9, 2019
henningkayser
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
Nov 21, 2019
robinedwards
added a commit
to rivelinrobotics/rivelin_pilz_industrial_motion
that referenced
this pull request
Jan 4, 2021
sjahr
pushed a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #1625 (although it could be isolated) and only consists of one commit.
I will rebase here once #1625 is merged.
As pointed out by @davetcoleman it seems weird to keep simple test functions like
isEmptywithin the fullPlanningSceneclass.This patch proposes to collect them in a new header in
moveit/utils/message_checks.h.Please review.