New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test case for #2824 #2878
Add test case for #2824 #2878
Conversation
cc3610a
to
2af6937
Compare
Codecov Report
@@ Coverage Diff @@
## master #2878 +/- ##
==========================================
+ Coverage 61.04% 61.36% +0.32%
==========================================
Files 373 373
Lines 31727 31727
==========================================
+ Hits 19366 19466 +100
+ Misses 12361 12261 -100
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort! Please have a look at the inline feedback.
moveit_ros/planning_interface/test/python_move_group_planning.py
Outdated
Show resolved
Hide resolved
moveit_ros/planning_interface/test/python_move_group_planning.py
Outdated
Show resolved
Hide resolved
moveit_ros/planning_interface/test/python_move_group_planning.py
Outdated
Show resolved
Hide resolved
moveit_ros/planning_interface/test/python_move_group_planning.test
Outdated
Show resolved
Hide resolved
a062d7c
to
90e456c
Compare
01fa12c
to
aa532af
Compare
Thanks for the comments. I have updated the PR. |
CI failure:
|
Format code Update test
aa532af
to
5dd4e37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the follow-up! See another inline nitpick.
Merging master to (hopefully) fix cross-platform CI.
moveit_planners/pilz_industrial_motion_planner/test/python_move_group_planning.py
Show resolved
Hide resolved
Co-authored-by: jschleicher <j.schleicher@pilz.de>
Sorry to leave this dangling for so long after review. It fell of the radar (as many others at the moment...) Thanks again! |
Test case for planning with collision objects that collide with the environment with Pilz planners (#2824). Related to #2843
Checklist