-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename header files so debs are installable #1443
Conversation
So it turns out this is more involved than I thought - the files we copied in are not what eventually got merged - in particular support for "namespace" has been lost - so our options are either:
EDIT: option A looks untenable |
f52d295
to
38b42aa
Compare
This now implements option B |
38b42aa
to
d12c8b5
Compare
@mikeferguson are we planning to eventually switch to option C, or keep it this way? |
@vatanaksoytezer I think we should eventually do option C (and I'll make sure there is a ticket for it) - but that is going to require at least 2 release cycles and somebody who is actually active on ros2_control (which I'm not). My goal with this PR is simply to get our debs to properly install - we can clean up the tech debt later |
Codecov Report
@@ Coverage Diff @@
## main #1443 +/- ##
==========================================
+ Coverage 50.90% 50.91% +0.02%
==========================================
Files 381 381
Lines 31784 31784
==========================================
+ Hits 16175 16179 +4
+ Misses 15609 15605 -4
Continue to review full report at Codecov.
|
I'll try to cut a new release today. |
Ticketed Option C here: #1451 |
Description
These files were copied in, now causing installation issues for our Debians: #1442
Checklist