Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pragma once as header include guard #1525

Merged

Conversation

J-Javan
Copy link
Contributor

@J-Javan J-Javan commented Aug 19, 2022

Description

The changes replace ifndef header include guards with pragma once.
See #882

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #1525 (ca1c561) into main (066e862) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1525      +/-   ##
==========================================
- Coverage   51.15%   51.14%   -0.00%     
==========================================
  Files         380      380              
  Lines       31758    31758              
==========================================
- Hits        16242    16239       -3     
- Misses      15516    15519       +3     
Impacted Files Coverage Δ
...planner/include/joint_limits_copy/joint_limits.hpp 100.00% <ø> (ø)
...nclude/joint_limits_copy/joint_limits_rosparam.hpp 88.47% <ø> (ø)
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.36% <0.00%> (-1.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for your contribution!

@vatanaksoytezer vatanaksoytezer merged commit 7d758de into moveit:main Aug 23, 2022
@J-Javan J-Javan deleted the convert-to-modern-include-guard branch August 23, 2022 14:30
@tylerjw tylerjw added the backport-humble Mergify label that triggers a PR backport to Humble label Oct 28, 2022
mergify bot pushed a commit that referenced this pull request Oct 28, 2022
tylerjw pushed a commit that referenced this pull request Oct 28, 2022
(cherry picked from commit 7d758de)

Co-authored-by: J. Javan <J-Javan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants