Factor out common cmake code to moveit_package macro

[lilustga]

Description

Created the moveit_common package containing a moveit_package() macro. This is used to apply basic cmake code to all moveit packages.

This macro allows CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS to be set for all moveit packages and allows for any new cmake code to be applied to all packages easily in the future.

Similar idea to this commit in nav2:
ms-iot/navigation2@3f65576

Checklist

• Required by CI: Code is auto formatted using clang-format
• Extend the tutorials / documentation reference
• Document API changes relevant to the user in the MIGRATION.md notes
• Create tests, which fail without this PR reference
• Include a screenshot if changing a GUI
• While waiting for someone to review your request, please help review another open pull request to support the maintainers

[codecov]

Codecov Report

Merging #285 into main will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   47.64%   47.64%           
=======================================
  Files         154      154           
  Lines       14844    14844           
=======================================
  Hits         7073     7073           
  Misses       7771     7771           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caab03c...c7f9281. Read the comment docs.

[lilustga]

Looks like clang format and gcc build have passed however there's a warning from moveit_planners_ompl causing clang build to fail.

The warning is 'ompl_interface::StateValidityChecker::isValid' hides overloaded virtual function [-Woverloaded-virtual]

It could be suppressed from the moveit_planners_ompl CMakeLists.txt, or should this be fixed?

[henningkayser]

Looks like clang format and gcc build have passed however there's a warning from moveit_planners_ompl causing clang build to fail.

The warning is 'ompl_interface::StateValidityChecker::isValid' hides overloaded virtual function [-Woverloaded-virtual]

It could be suppressed from the moveit_planners_ompl CMakeLists.txt, or should this be fixed?

@lilustga Well, this is strange. I don't know how this issue could have been introduced here, it should be checking for the same warnings as before. I think it should be fixed if possible.

[henningkayser]

Looks good to me. Please consider moving the moveit_common macros to the top with a short comment, I think it would be cleaner and more consistent.

[tylerjw]

I approve this approach. It is cleaner and a nice way to consolidate common cmake settings for the whole repo. Please remove the commented out code.

[lilustga]

Travis clang build and code coverage look like they failed due to a transient issue. @henningkayser are you able to restart the build checks (I think it requires write access)?

[henningkayser]

Travis clang build and code coverage look like they failed due to a transient issue. @henningkayser are you able to restart the build checks (I think it requires write access)?

It seems like the checks work now, but there are some unrelated CI fixes I'm currently working on

[henningkayser]

CI issues are fixed with #294. After that, I would squash-merge this PR