-
Notifications
You must be signed in to change notification settings - Fork 3
Rework the script; update README #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ayush Ghosh <149644562+ayushgnv@users.noreply.github.com> Co-authored-by: Ian Chen <ichen@openrobotics.org> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
0126af1 to
67440a4
Compare
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
iche033
reviewed
Oct 23, 2025
* modified script to adhere to videos Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Update warehouse_simulation_script.py * Update warehouse_simulation_script.py --------- Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
|
Thank you for your review. |
iche033
reviewed
Oct 25, 2025
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
adamdbrw
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the previous works I refactored the python script to follow the structure of the agreed scenario with three segments recorded in different simulators.
I tried to keep it as similar as possible to the previous implementation (in #2), but some differences can be noticed.
The script was primarily refactored to:
I also included some small changes in the README file, that should be completely refactored in a separate PR.
This script was tested in O3DE only.
@ayushgnv @iche033 @adamdbrw
Please feel free to comment on any parts that still need some work.