Skip to content

Make sure package names don't contain invalid/unprintable chars#31

Merged
christophebedard merged 1 commit intomainfrom
christophebedard/make-sure-package-names-dont-contain-unprintable-chars
Mar 30, 2026
Merged

Make sure package names don't contain invalid/unprintable chars#31
christophebedard merged 1 commit intomainfrom
christophebedard/make-sure-package-names-dont-contain-unprintable-chars

Conversation

@christophebedard
Copy link
Copy Markdown
Member

This aims to detect my mistake here: ros2/rclpy#1629 (comment). I copied a package name from the GitHub PR files list, which included an invisible Unicode character (U+200E LEFT-TO-RIGHT MARK, UTF-8: E2 80 8E). This was very hard to figure out just by looking at the weird CI failure:

Package '‎rclpy' specified with --packages-above-and-dependencies was not found

With this PR:

$ ros-ci-for-pr -p ros2/rclpy#1629 -k ‎rclpy -t rolling -b -c
usage: ros-ci-for-pr [--branch BRANCH] [-p PULLS [PULLS ...] | -i] [-h] [-k PACKAGES [PACKAGES ...]] [-t TARGET] [-b] [-c] [--only-fixes-test] [--colcon-build-args COLCON_BUILD_ARGS]
                     [--colcon-test-args COLCON_TEST_ARGS] [--cmake-args CMAKE_ARGS]
ros-ci-for-pr: error: argument -k/--packages: package name contains unprintable characters: '\u200erclpy'

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Copy link
Copy Markdown
Member

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophebedard christophebedard merged commit 89fb342 into main Mar 30, 2026
2 checks passed
@christophebedard christophebedard deleted the christophebedard/make-sure-package-names-dont-contain-unprintable-chars branch March 30, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants