Added comment to document new Rviz Marker action #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davetcoleman Should the comment on the "action" field also be updated? There isn't really any description up above that ADD/DELETE/MODIFY and now DELETE_ALL are intended for that particular field. |
|
+1 other than that. |
|
Good point @mikeferguson It would be great to put a comment above the list for which enums are for which fields. Otherwise looks good +1 |
|
Comment added |
|
+1 |
|
@tfoote this is ready to merge. |
|
Merged with a rebase on the last pull-request 5f14bdd |
|
i was just checking if this was ever updated for ROS-J, and I see it was. thanks @tfoote ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not change the MD5 sum of common_msgs, but merely documents a new feature that can be optionally used.
I do advocate we enable this action type in ROS-J.
This change documents ros-visualization/rviz#781