Add support for passing arguments to constructors#291
Conversation
- updated `create*Instance` methods to forward arguments to plugin constructors using class_loader interface traits Signed-off-by: pum1k <55055380+pum1k@users.noreply.github.com>
|
Pulls: #291
|
|
@ahcorde are you aware this breaks all existing uses of pluginlib? Currently Nav2 does not build due to this, which I highly suspect means that every plugin user would need to update their use of pluginlib to work (since we don't do anything fancy). I think there either needs to be a workaround for objects without constructor arguments or a detailed migration guide for what updates need to be specifically made. Personally I think a library like this needs a tick-tock migration pattern to give folks time and awareness, but feels to me like this could be done non-disruptively (though this is not my area of expertise) |
|
@SteveMacenski the Nav2 test is broken, because it depends on private parts of the pluginlib. Code calling the public APIs of pluginlib requires no change. |
|
Huh - OK - false alarm. Still need to figure out a solution, but feel free to ignore me then 🙃 I thought I saw this show before, but turns out I'm watching a different channel |
3 participants
Description
This PR allows passing arguments to plugin constructors. This is done by exposing a new feature of class_loader added in ros/class_loader#223.