Collapse testing back into pluginlib package. #134
Conversation
|
mjcarroll
force-pushed
the
collapse_testing
branch
from
627cae8
to
1bc5099
Compare
|
|
|
There was a problem hiding this comment.
I tested this on Xenial and the pluginlib tests ran without issue.
I am somewhat concerned that the fixture package.xml could be picked up by some tools (not colcon, clearly as the build did not fail) as part of a valid package all its own. Since the file is copied out during the test phase this could be mitigated by naming the source file something like fixture_package.xml instead.
I liked the acceptance tests when they were introduced as a top-level package in #130 but I'm not sure if it's worth the CMake hoops here to have them.
The spec forbids nesting of packages so that shouldn't be a problem with compliant tools. |
No more |
|
I will do as you suggest and change the name, so it won't be picked up by simple searches in the source space, at least, but it's good to know that it shouldn't choke any of the tooling. |
|
Nevermind on renaming, because CMake doesn't support it on New CI:
|
|
|
|
Just realized I had some vestigial debug output that needed to be removed. |
|
This needs ros2/tinyxml2_vendor#3 before merging |
| rcutils | ||
| TinyXML2 | ||
| ) | ||
| target_link_libraries(${PROJECT_NAME}_utest ${TinyXML2_LIBRARIES}) |
There was a problem hiding this comment.
Nit, I think ament_target_dependencies(... TinyXML2) above does this already.
There was a problem hiding this comment.
Correct, this was an accident. Thanks!
Merges testing back into the pluginlib package.
Depends on ros2/tinyxml2_vendor#3