Skip to content

Remove extraneous link lines.#135

Merged
mjcarroll merged 1 commit intoros2from
cleanup_over_linking
Dec 12, 2018
Merged

Remove extraneous link lines.#135
mjcarroll merged 1 commit intoros2from
cleanup_over_linking

Conversation

@mjcarroll
Copy link
Copy Markdown
Member

@mjcarroll mjcarroll commented Dec 11, 2018

Addresses @sloretz's comment from #134.

@mjcarroll
Copy link
Copy Markdown
Member Author

mjcarroll commented Dec 11, 2018

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@nuclearsandwich
Copy link
Copy Markdown
Member

nuclearsandwich commented Dec 11, 2018 

14:48:53 CMake Error at /opt/ros/crystal/share/ament_cmake_target_dependencies/cmake/ament_target_dependencies.cmake:42 (message):
14:48:53   ament_target_dependencies() the passed package name 'TinyXML2' was not
14:48:53   found before

The PR job is failing because we need to release the updated tinyxml2_vendor package

nuclearsandwich
nuclearsandwich approved these changes Dec 11, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI. the failure on the PR job is due to tinyxml2_vendor being out of date on the farm.

@mjcarroll mjcarroll merged commit 003000f into ros2 Dec 12, 2018
@nuclearsandwich nuclearsandwich deleted the cleanup_over_linking branch December 12, 2018 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

@sloretz sloretz sloretz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjcarroll @nuclearsandwich @sloretz