Skip to content

Heavily cleanup pluginlib. #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

Heavily cleanup pluginlib. #265

merged 1 commit into from
Dec 3, 2024
+599 −613

Conversation

clalancette
Copy link
Contributor

In particular:

  1. Move pluginlib to the top directory. The main reason to do this is so that our copyright checks actually work properly here. But this also gets rid of an unnecessary directory.
  2. Enable linting. This ensures that this project adheres to our general guidelines.

@clalancette
Copy link
Contributor Author

clalancette commented Oct 25, 2024 •
edited
Loading

Pulls: #265
Gist: https://gist.githubusercontent.com/clalancette/9c465b2e78fbe08cfccf90e46132e8f5/raw/1e1ae6aa7e2a3d0596ee79edd9f79c6bb84f518c/ros2.repos
BUILD args: --packages-above-and-dependencies pluginlib
TEST args: --packages-above pluginlib
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14730

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette clalancette force-pushed the clalancette/enable-linting branch 2 times, most recently from d3f7844 to e4a8cbb Compare October 26, 2024 17:07
@clalancette
Heavily cleanup pluginlib.
8e861c0 
In particular:

1.  Move pluginlib to the top directory.  The main reason
to do this is so that our copyright checks actually work
properly here.  But this also gets rid of an unnecessary
directory.
2.  Enable linting.  This ensures that this project adheres
to our general guidelines.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette force-pushed the clalancette/enable-linting branch from e4a8cbb to 8e861c0 Compare December 2, 2024 22:35
@clalancette
Copy link
Contributor Author

clalancette commented Dec 2, 2024 •
edited
Loading

Pulls: #265
Gist: https://gist.githubusercontent.com/clalancette/effa173e3f419ddc862042ddb6bb5e2a/raw/1e1ae6aa7e2a3d0596ee79edd9f79c6bb84f518c/ros2.repos
BUILD args: --packages-above-and-dependencies pluginlib
TEST args: --packages-above pluginlib
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14892

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette clalancette merged commit 75d9f00 into rolling Dec 3, 2024
3 checks passed
@clalancette clalancette deleted the clalancette/enable-linting branch December 3, 2024 02:23
This was referenced Oct 8, 2025
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clalancette @mjcarroll