Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rospy] add current_real docstring in timer.py #2178

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

knorth55
Copy link
Contributor

this PR adds docstring for current_real in TimerEvent.
this docstring is same as roswiki.
http://wiki.ros.org/roscpp/Overview/Timers

@knorth55 knorth55 changed the title [rospy] add current_reald doc in timer.py [rospy] add current_real doc in timer.py Aug 20, 2021
@knorth55 knorth55 changed the title [rospy] add current_real doc in timer.py [rospy] add current_real docstring in timer.py Aug 20, 2021
Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! One suggestion below.

clients/rospy/src/rospy/timer.py Outdated Show resolved Hide resolved
Co-authored-by: Jacob Perron <jacob@openrobotics.org>
@knorth55
Copy link
Contributor Author

knorth55 commented Sep 1, 2021

@jacobperron thank you for the review! I updated this PR.

Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacobperron jacobperron merged commit 11ebadc into ros:noetic-devel Sep 1, 2021
@knorth55 knorth55 deleted the current-real-doc branch September 2, 2021 02:38
jacobperron added a commit that referenced this pull request Sep 21, 2021
* add current_reald doc in timer.py

* fix docstring in timer.py

Co-authored-by: Jacob Perron <jacob@openrobotics.org>

Co-authored-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit that referenced this pull request Jan 6, 2022
* add current_reald doc in timer.py

* fix docstring in timer.py

Co-authored-by: Jacob Perron <jacob@openrobotics.org>

Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants