Add GTSAM as source package #23198
Merged
Add GTSAM as source package #23198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlblancoc
requested review from
clalancette,
nuclearsandwich and
tfoote
as code owners
clalancette
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
In general, please open a separate PR per ROS distribution. The general reason is that they are not all on the same release schedule, so it may be the case that we can't merge the PR because one of the ROS distros is in a freeze at the moment.
That being said, you picked an opportune moment to open this one. In this case, all of the ROS distros in here are currently not frozen, so we can merge this as-is.
|
Ok, that's good to know and totally makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added as a follow up of borglab/gtsam#173