Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yourdfpy to Python rosdeps #41102

Merged
merged 4 commits into from
May 14, 2024
Merged

Add yourdfpy to Python rosdeps #41102

merged 4 commits into from
May 14, 2024

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented May 8, 2024

Please add the following dependency to the rosdep database.

Package name:

yourdfpy

Package Upstream Source:

https://github.com/clemense/yourdfpy/

Purpose of using this:

yourdfpy is a currently-maintained package for loading and manipulating URDFs in Python. The other comparable library that is in the rosdep, urdfpy has not been updated for years and is having dependency version issues.

Links to Distribution Packages

@amalnanavati amalnanavati requested a review from a team as a code owner May 8, 2024 18:48
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label May 8, 2024
ahcorde
ahcorde previously requested changes May 9, 2024
rosdep/python.yaml Show resolved Hide resolved
@amalnanavati amalnanavati requested a review from ahcorde May 9, 2024 15:36
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I can't say that I'm enamored of having another Python URDF parser around, there is nothing technically wrong with this.

Just keep in mind that because this is a pip-only package, you won't be able to release packages on the buildfarm that depend on this.

rosdep/python.yaml Outdated Show resolved Hide resolved
Co-authored-by: Scott K Logan <logans@cottsay.net>
@amalnanavati amalnanavati requested a review from cottsay May 14, 2024 16:29
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@cottsay cottsay dismissed ahcorde’s stale review May 14, 2024 18:32

Requested changes resolved

@cottsay cottsay merged commit 63e0b9e into ros:master May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants