Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python-transforms3d-pip For All Ubuntu Versions #42168

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

danthony06
Copy link
Contributor

Please add the following dependency to the rosdep database.

Package name:

python-transforms3d-pip

Package Upstream Source:

transforms3d

Purpose of using this:

I need this package for rolling. I think every supported distribution is currently explicitly called out, except for noble, so I simplified the rule to install it for all Ubuntu versions.

Distro packaging links:

Links to Distribution Packages

This is a pip package.

Please Add This Package to be indexed in the rosdistro.

rolling

The source is here:

https://matthew-brett.github.io/transforms3d/

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

I need python3-transforms3d-pip in `rolling`. Currently, every other supported distribution is explicitly called out, and I do not see a good reason for this, so I simplified the rule to install the package for all Ubuntu versions.
Adding python3d-transforms3d-pip to All Ubuntu Releases
@danthony06 danthony06 requested a review from a team as a code owner July 22, 2024 22:32
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Jul 22, 2024
@clalancette clalancette merged commit 6271d97 into ros:master Jul 23, 2024
4 checks passed
@danthony06
Copy link
Contributor Author

danthony06 commented Jul 23, 2024 via email

@danthony06
Copy link
Contributor Author

@clalancette Sorry, it looks like this may be causing problems on rolling. My ROS-I CI is failing here. It looks like Ubuntu 24.04 is no longer allowing us to install pip package system-wide in the past. Is this something we should update the ROS-I CI pipeline to work with, or is this a larger problem with pip packages in rolling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants