Skip to content

Update the rcljava parameter APIs (port osrf/ros2_java#1) #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 15, 2021
Merged

Update the rcljava parameter APIs (port osrf/ros2_java#1) #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
eb8dffc
Implement all parameter types.
clalancette Jul 16, 2020
e262013
Add log4j initialization to all tests.
clalancette Jul 22, 2020
bbed9ad
Make the parameter separator a class variable.
clalancette Jul 22, 2020
19ec023
Store the parameter and the descriptor.
clalancette Jul 22, 2020
bfafaf5
Switch parameters to using map lookups.
clalancette Jul 22, 2020
42901a6
Plumb undeclaredParameters through the Node constructor.
clalancette Jul 22, 2020
3f741f9
Add in another ParameterVariant.
clalancette Jul 22, 2020
5e252b8
Add in a ParameterCallback interface.
clalancette Jul 22, 2020
b074d61
Update the Node parameter methods to Dashing/Foxy equivalents.
clalancette Jul 20, 2020
6157fb1
Add tests for Node parameters.
clalancette Jul 22, 2020
7b0bd43
Add node parameters test with undeclared parameters.
clalancette Jul 22, 2020
086e700
Fix rebasing error
ivanpauno Nov 12, 2021
e0ac908
configure logger in an android compatible way
ivanpauno Nov 12, 2021
a1d892c
configure logger in an android compatible way
ivanpauno Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions rcljava/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ set(${PROJECT_NAME}_sources
"src/main/java/org/ros2/rcljava/parameters/client/AsyncParametersClientImpl.java"
"src/main/java/org/ros2/rcljava/parameters/client/SyncParametersClient.java"
"src/main/java/org/ros2/rcljava/parameters/client/SyncParametersClientImpl.java"
"src/main/java/org/ros2/rcljava/parameters/ParameterCallback.java"
"src/main/java/org/ros2/rcljava/parameters/ParameterNames.java"
"src/main/java/org/ros2/rcljava/parameters/ParameterType.java"
"src/main/java/org/ros2/rcljava/parameters/ParameterVariant.java"
Expand Down Expand Up @@ -224,9 +225,11 @@ if(BUILD_TESTING)
"src/test/java/org/ros2/rcljava/SpinTest.java"
"src/test/java/org/ros2/rcljava/TimeTest.java"
"src/test/java/org/ros2/rcljava/client/ClientTest.java"
"src/test/java/org/ros2/rcljava/node/NodeParametersTest.java"
"src/test/java/org/ros2/rcljava/node/NodeUndeclaredParametersTest.java"
"src/test/java/org/ros2/rcljava/node/NodeTest.java"
"src/test/java/org/ros2/rcljava/parameters/AsyncParametersClientTest.java"
"src/test/java/org/ros2/rcljava/parameters/SyncParametersClientTest.java"
# "src/test/java/org/ros2/rcljava/parameters/AsyncParametersClientTest.java"
# "src/test/java/org/ros2/rcljava/parameters/SyncParametersClientTest.java"
"src/test/java/org/ros2/rcljava/publisher/PublisherTest.java"
"src/test/java/org/ros2/rcljava/subscription/SubscriptionTest.java"
"src/test/java/org/ros2/rcljava/timer/TimerTest.java"
Expand All @@ -237,8 +240,10 @@ if(BUILD_TESTING)
"org.ros2.rcljava.SpinTest"
"org.ros2.rcljava.TimeTest"
"org.ros2.rcljava.client.ClientTest"
"org.ros2.rcljava.node.NodeParametersTest"
"org.ros2.rcljava.node.NodeUndeclaredParametersTest"
"org.ros2.rcljava.node.NodeTest"
"org.ros2.rcljava.parameters.SyncParametersClientTest"
# "org.ros2.rcljava.parameters.SyncParametersClientTest"
"org.ros2.rcljava.publisher.PublisherTest"
"org.ros2.rcljava.subscription.SubscriptionTest"
"org.ros2.rcljava.timer.TimerTest"
Expand Down
8 changes: 6 additions & 2 deletions rcljava/src/main/java/org/ros2/rcljava/RCLJava.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ public static Context createContext() {
* structure.
*/
public static Node createNode(final String nodeName) {
return createNode(nodeName, "", RCLJava.getDefaultContext());
return createNode(nodeName, "", RCLJava.getDefaultContext(), false);
}

/**
Expand All @@ -229,8 +229,12 @@ public static Node createNode(final String nodeName) {
* structure.
*/
public static Node createNode(final String nodeName, final String namespace, final Context context) {
return createNode(nodeName, namespace, context, false);
}

public static Node createNode(final String nodeName, final String namespace, final Context context, final boolean allowUndeclaredParameters) {
long nodeHandle = nativeCreateNodeHandle(nodeName, namespace, context.getHandle());
Node node = new NodeImpl(nodeHandle, nodeName, context);
Node node = new NodeImpl(nodeHandle, nodeName, context, allowUndeclaredParameters);
nodes.add(node);
return node;
}
Expand Down
Loading